Merged
Conversation
Game Test Results✅ Success
Workflow run: #395 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how artifact enhancement attribute modifiers are generated so their AttributeModifier IDs can be made unique per Curios slot/context, reducing modifier ID collisions when multiple artifacts are equipped.
Changes:
- Pass the Curios-provided
ResourceLocation iddown intoArtifactEnhancementComponentwhen generating attribute modifiers. - Add an overloaded
getAttributeModifiers(ResourceLocation curiosId)that rewrites modifier IDs to include the Curios identifier. - Prefix newly generated modifier keys with
artifact_enhancement.to better namespace IDs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/java/com/altnoir/mia/common/item/abs/IEArtifact.java |
Threads the Curios id into artifact enhancement attribute modifier generation. |
src/main/java/com/altnoir/mia/common/component/ArtifactEnhancementComponent.java |
Adds Curios-aware modifier ID rewriting and namespaces modifier key generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #105